Alice and Hannah - VideoStoreAPI by hertweckhr1 · Pull Request #6 · Ada-C10/VideoStoreAPI

hertweckhr1 · 2018-11-09T05:28:56Z

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	Rentals seed data have foreign keys so we knew that customers would have many rentals and movies would have many rentals, so rentals would belong to both.
What would be the Big-O time complexity of your /customers & /movies endpoints? What does the time complexity depend on? Explain your reasoning.	O(n) because we are looping through every customer and movie. When we sort using ruby methods, it would be n log n because we are using a type of quick sort. We are unsure of time complexity when using database sql commands, but we did look it up and could not find clear answer.
What is the Big-O time complexity of the `POST /rentals/check-in` endpoint? What does the time complexity depend on? Explain your reasoning.	We loop through the movies, then customers, and then rentals. We believe this is O(n) because we loop through each one of these separately. Again we do not know exact time complexity using db operations.
Describe a set of positive and negative test cases you implemented for a model.	In movies controller we tested available? to see if the movie was available to checkout. Positive: We returned true if available inventory is greater than 0. Negative: we returned false if available inventory is 0.
Describe a set of positive and negative test cases you implemented for a controller.	In the rentals controller we check overdue rentals. Positive: it will return all overdue items that have not been checked in and the due date has passed. Negative: we make sure it will render the empty json view explaining no records found when there are no overdue rentals.
How does your API respond when bad data is sent to it?	We make it look really pretty and customize responses with rabl to let our customers know more specifically what they did wrong. We have such views like bad request, notfound, empty array, and denied to explain all possible cases.
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	In the customer model we wrote a method called "overdue_items?" This checks to see if a the rental checkin_date is equal to nil and if the rental due date is before the current date. If we get any overdue items we return true, otherwise we return false. This helps clean up our rentals controller so the business logic to test checkout is not in the controller.
Do you have any recommendations on how we could improve this project for the next cohort?	We felt like we had a lot of project time this week, but we did not need as much time to complete project. We would like to start Javascript sooner.
Link to Trello	https://www.lucidchart.com/invitations/accept/be102190-f263-425e-b86c-5ceac70a1076
Link to ERD	https://trello.com/b/rt1Kkr6q/hannah-alices-videostoreapi
Summary

…dex, added rabl gem and added forgery protection to controllers

…gery check in order for postman to work

…ts for overdue items and available_inventory

…method names checkin checkout

…t endpoints

CheezItMan · 2018-11-11T19:59:18Z

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commits and good commit messages
Comprehension questions	Check, the database operations are a little hard to judge, but you're correct.
General
Business Logic in Models	Check
All required endpoints return expected JSON data	Check
Requests respond with appropriate HTTP Status Code	Check
Errors are reported	Check
Testing
Passes all Smoke Tests	check
Model Tests - all relations, validations, and custom functions test positive & negative cases	Check, but you have one failing test
Controller Tests - URI parameters and data in the request body have positive & negative cases	Check, but you have a couple of failing tests.
Overall	Pretty good job, you hit all the learning goals. You should use ERB tags in the fixtures to prevent the due dates you have hardcoded now, from causing tests to fail in the future. Otherwise excellent job.

CheezItMan · 2018-11-11T19:46:18Z

test/controllers/rentals_controller_test.rb

+      movie = movies(:movieone)
+      starting_inventory = movie.available_inventory
+
+      expect {


This test is failing because this customer has overdue items and so is forbidden from checking out a movie.

Fixed! The Date.tomorrow for customer one in the yml file fixed everything.

CheezItMan · 2018-11-11T19:46:54Z

test/models/customer_test.rb

+      end
+
+      it "returns false if customer has no overdue items" do
+        expect(customer.overdue_items?).must_equal false


This test is failing, because this customer has an item which was due yesterday. If you want to fix this, I would use erb tags to set the due date to Date.tomorrow, so it would never be overdue.

Ah! Totally forgot about these dates. Fixed!

CheezItMan · 2018-11-11T19:47:25Z

test/controllers/rentals_controller_test.rb

+
+      body = JSON.parse(response.body)
+      expect(body).must_be_kind_of Array
+      expect(body.length).must_equal 1


This test is failing, because this customer has two overdue movies.

CheezItMan · 2018-11-11T20:00:36Z

app/controllers/customers_controller.rb

+    @customers = sort_and_paginate(sort_options, list, params)
+  end
+
+  def zomg


CheezItMan · 2018-11-11T20:00:57Z

app/controllers/application_controller.rb

@@ -0,0 +1,92 @@
+class ApplicationController < ActionController::API
+


I like the helper methods you put in here.

hertweckhr1 and others added 30 commits November 5, 2018 12:50

added models, relationships between models and seeded database

41006c5

New rails project

7fd1ae2

Fixed Merge Confict

000e9ca

Wrote relationship and validation tests for rental, movie, and customer

359dee6

Added zomg to routes

3ec79d5

completed writing validation tests

55fbfd0

rabl gem added

00a4824

filled in movie controller index, show create, customer controller in…

2ee5170

…dex, added rabl gem and added forgery protection to controllers

fixed errors in movie and index controllers plus needed to remove for…

b1ede1f

…gery check in order for postman to work

implemented rabl to format json views

176892a

Implemented Rabl for both customers and movies controller

c49b66e

Moved logic to controller

7acb2ac

Wave 2 Smoke Test Passes

5b87079

controller tests for customers and movies

f89c559

Created check in column for rental

0991bc5

checkin and checkout tests written in tdd format along with model tes…

b2b5621

…ts for overdue items and available_inventory

added controller tests for checked out

e0d6a9c

completed controller for checkin

1d998a2

smoke tests now passing when routes changed to check-in/checkout and …

cdd69e2

…method names checkin checkout

changed notfound into layouts for json.rabl

acb06c1

Reconfigured controller based on Postman output

8cc9e28

Refactored check-in and check-out to rentals controller

756f999

queries added to customer index

ddf64e5

queries added for movies index

7571e70

Wrote custom method tests for rental model after refactoring code

73b471c

customer query tests written and passing

3699929

Completed tests for sorting and pagination for movies and customers

3604f7e

Refactored sort and paginate

b6f3640

Added zomg route with rendered json

8e15a22

Added current and history endpoints, and refactored model relationships

4a4eb77

alicehsiao and others added 12 commits November 7, 2018 20:47

Broke some things and now learning SQL

2f2edfb

Changed current.json.rabl

e46988e

adjusted tests to include ok in index json views

6d15ba2

All fields can be sorted for movies and customers inventory managemen…

173f622

…t endpoints

Resolved merge conflict

9470a9e

finished overdue sort and paginate

11e63fc

Completed tests for current methods in customer and movies controller

c87d078

Completed history tests for movies and customers controller

0ef3d10

rental controller tests written for rentals overdue

429b6ad

Reorganized application controller

7e6529d

Merge branch 'master' of https://github.com/hertweckhr1/VideoStoreAPI

86d65eb

updated model relationships we weren't using

6964e47

CheezItMan reviewed Nov 11, 2018

View reviewed changes

Changed due date for customer in yml file

3ae42b7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alice and Hannah - VideoStoreAPI#6

Alice and Hannah - VideoStoreAPI#6
hertweckhr1 wants to merge 43 commits intoAda-C10:masterfrom
hertweckhr1:master

hertweckhr1 commented Nov 9, 2018

Uh oh!

CheezItMan commented Nov 11, 2018

Uh oh!

CheezItMan Nov 11, 2018

Uh oh!

alicehsiao Nov 11, 2018

Uh oh!

CheezItMan Nov 11, 2018

Uh oh!

alicehsiao Nov 11, 2018

Uh oh!

CheezItMan Nov 11, 2018

Uh oh!

alicehsiao Nov 11, 2018

Uh oh!

CheezItMan Nov 11, 2018

Uh oh!

CheezItMan Nov 11, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,92 @@
		class ApplicationController < ActionController::API

Conversation

hertweckhr1 commented Nov 9, 2018

Video Store API

Comprehension Questions

Uh oh!

CheezItMan commented Nov 11, 2018

Video Store

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants